Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(course-users): add activist role #2282

Merged

Conversation

ThorsAngerVaNeT
Copy link
Contributor

@ThorsAngerVaNeT ThorsAngerVaNeT commented Sep 6, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

We have an activist field in the user table that is not used and can't be updated anyhow in UI. This field could be used for more convenient filtering in Heroes Radar.

πŸ’‘ Background and solution

Added Activist role in Course Users. That way we could have data on which course students became activists and update the activist field in the user table.
The Activist role doesn't yet have any additional access on courses.

image
image

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@apalchys
Copy link
Member

apalchys commented Sep 6, 2023

@valerydluski please review

@valerydluski
Copy link
Contributor

@apalchys approved

@apalchys apalchys merged commit 72cf45c into rolling-scopes:master Sep 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants