Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interview): add feedback tag #2276

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

aaliakseyenka
Copy link
Contributor

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

Adds interview tags
Screenshot 2023-08-20 at 18 39 22

@aaliakseyenka aaliakseyenka force-pushed the interview-feedback-6 branch 2 times, most recently from 987ef19 to 9cf0ab4 Compare August 29, 2023 12:38
Base automatically changed from interview-feedback-5 to master August 29, 2023 18:59
@github-actions
Copy link

📦 Next.js Bundle Analysis for client

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 148.98 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/course/interview/[type]/feedback 323.76 KB 472.74 KB 94.55% (🟡 +0.03%)
/course/mentor/interview-wait-list 328.62 KB 477.6 KB 95.52% (🟡 +0.04%)
/course/mentor/interviews 342.68 KB 491.66 KB 98.33% (🟡 +0.04%)
/course/student/auto-test 367.79 KB 516.77 KB 103.35% (🟡 +0.01%)
/course/student/auto-test/task 367.71 KB 516.69 KB 103.34% (+/- <0.01%)
/course/student/dashboard 387.24 KB 536.22 KB 107.24% (+/- <0.01%)
/course/student/interviews 284.07 KB 433.05 KB 86.61% (🟡 +0.03%)
/course/submit-scores 405.07 KB 554.05 KB 110.81% (+/- <0.01%)
/profile 399.36 KB 548.34 KB 109.67% (🟡 +0.04%)
/registry/mentor 345.86 KB 494.84 KB 98.97% (+/- <0.01%)
/registry/student 345.86 KB 494.84 KB 98.97% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@aaliakseyenka aaliakseyenka merged commit bf3d231 into master Aug 30, 2023
6 checks passed
@aaliakseyenka aaliakseyenka deleted the interview-feedback-6 branch August 30, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants