-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reexport commonjs #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
Benchmark Results
|
underfin
commented
Oct 21, 2023
if importer.is_entry { | ||
Some(symbol_ref) | ||
// FIXME: this is wrong, should be generate local symbol for runtime symbol | ||
// Some(importer.generate_local_symbol(&mut self.graph.symbols, *exported)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rust ownership can't get mutable refernece of module at same,i will create linker module struct to avoid it at next pr.
hyf0
reviewed
Oct 21, 2023
hyf0
reviewed
Oct 21, 2023
hyf0
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pr is will implement some case for reexport commonjs. The esbuild example see here.
Here followed esbuild result and make sure if the symbol not found error happend at real position.
Implement Detail
Resolution::Runtime
to mark the symbol will being resolved for runtime at linker imports/exports. It worked for export star from commonjs and import symbol from commonjs.UnresolvedSymbols
and will render its reference.UnresolvedSymbols
and will render its reference.The
UnresolvedSymbols
will record the symbol come from importee namespace symbol and original name. And it codgena
to_ns.a
.ResolvedExport::Runtime
to mark the symbol reexported form commonjs, egexport { a} from 'cjs'
, it will render the resolved_exports toa() => cjs_ns.a
related #36.
Test Plan
Added.