Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic chunk name for dynamic chunk and shared chunk #49

Closed
Tracked by #43
hyf0 opened this issue Oct 12, 2023 · 1 comment · Fixed by #381
Closed
Tracked by #43

Deterministic chunk name for dynamic chunk and shared chunk #49

hyf0 opened this issue Oct 12, 2023 · 1 comment · Fixed by #381
Assignees
@hyf0
Labels
bug Something isn't working
Milestone
Pending

Comments

@hyf0
Copy link
Member

hyf0 commented Oct 12, 2023 •
edited
Loading

@hyf0 hyf0 added the bug Something isn't working label Oct 12, 2023
@hyf0
Copy link
Member Author

hyf0 commented Oct 12, 2023

The issue affects the snapshot tests output and correctness.

@hyf0 hyf0 mentioned this issue Oct 12, 2023
Closed
10 tasks
@hyf0 hyf0 assigned hyf0 and unassigned underfin Oct 25, 2023
@hyf0 hyf0 added this to the Pending milestone Oct 31, 2023
@hyf0 hyf0 mentioned this issue Nov 23, 2023
Merged
@hyf0 hyf0 linked a pull request Nov 23, 2023 that will close this issue
fix: more meaningful chunk filename #381
Merged
@hyf0 hyf0 closed this as completed in #381 Dec 4, 2023
hyf0 added a commit that referenced this issue Dec 4, 2023
@hyf0
fix: more meaningful chunk filename (#381)
47b4b6d 
<!-- Thank you for contributing! -->

### Description

Closes #49.

<!-- Please insert your description here and provide especially info about the "what" this PR is solving -->

### Test Plan

<!-- e.g. is there anything you'd like reviewers to focus on? -->

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyf0 hyf0

Labels
bug Something isn't working
Projects
None yet
Milestone
Pending
Development

Successfully merging a pull request may close this issue.

fix: more meaningful chunk filename rolldown/rolldown
2 participants
@underfin @hyf0