Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import statements don't get hoisted in compile-time #418

Closed
hyf0 opened this issue Jan 28, 2024 · 1 comment
Closed

Import statements don't get hoisted in compile-time #418

hyf0 opened this issue Jan 28, 2024 · 1 comment
Assignees
@hyf0
Labels
bug Something isn't working

Comments

@hyf0
Copy link
Member

hyf0 commented Jan 28, 2024

Noticed in c82395d.

See fixture crates/rolldown/tests/esbuild/default/es6_from_common_js for details.
@hyf0 hyf0 added bug Something isn't working ast-based integration labels Jan 28, 2024
@hyf0 hyf0 self-assigned this Jan 28, 2024
@hyf0
Copy link
Member Author

hyf0 commented Feb 3, 2024

This should be done before the finalize pass. Otherwise, we might fall into the wrong execution order.

@hyf0 hyf0 closed this as completed in 276bbae Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyf0 hyf0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyf0