Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: treeshaking in module level #382

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat: treeshaking in module level #382

merged 1 commit into from
Dec 4, 2023
+8 −2

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 23, 2023

Description

Test Plan

This was referenced Nov 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@hyf0
Copy link
Member Author

hyf0 commented Nov 23, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 23, 2023
Merged
Merged
@hyf0 hyf0 force-pushed the 11-23-fix_more_meaningful_chunk_filename branch from 5b25629 to 52e7db7 Compare November 23, 2023 14:55
@hyf0 hyf0 force-pushed the 11-23-feat_treeshaking_in_module_level branch from 937684f to e03368e Compare November 23, 2023 14:55
@hyf0 hyf0 mentioned this pull request Nov 24, 2023
Merged
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 27, 2023 •
edited by hyf0
Loading

Merge activity

@hyf0 hyf0 force-pushed the 11-23-fix_more_meaningful_chunk_filename branch from 52e7db7 to d9427fc Compare November 27, 2023 05:15
@hyf0 hyf0 force-pushed the 11-23-feat_treeshaking_in_module_level branch from e03368e to a1621a7 Compare November 27, 2023 05:15
milesj
milesj reviewed Nov 27, 2023
View reviewed changes
crates/rolldown/src/bundler/stages/link_stage.rs
@@ -239,6 +239,7 @@ impl LinkStage {
modules: &'a ModuleVec,
symbols: &'a Symbols,
is_included_vec: &'a mut IndexVec<ModuleId, IndexVec<StmtInfoId, bool>>,
is_module_included_vec: &'a mut IndexVec<ModuleId, bool>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, is IndexVec faster than a simple HashSet?

@hyf0 hyf0 force-pushed the 11-23-fix_more_meaningful_chunk_filename branch from d9427fc to 8710382 Compare December 4, 2023 02:09
@hyf0 hyf0 force-pushed the 11-23-feat_treeshaking_in_module_level branch from a1621a7 to 353e012 Compare December 4, 2023 02:09
@hyf0 hyf0 force-pushed the 11-23-fix_more_meaningful_chunk_filename branch from 8710382 to 950dea1 Compare December 4, 2023 02:15
Base automatically changed from 11-23-fix_more_meaningful_chunk_filename to main December 4, 2023 02:16
@hyf0 hyf0 force-pushed the 11-23-feat_treeshaking_in_module_level branch from 353e012 to 970d53d Compare December 4, 2023 02:16
@hyf0 hyf0 merged commit 6f8b03f into main Dec 4, 2023
6 checks passed
@hyf0 hyf0 deleted the 11-23-feat_treeshaking_in_module_level branch December 4, 2023 02:17
@hyf0 hyf0 mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesj milesj milesj left review comments

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyf0 @Boshen @milesj @underfin