feat: prepare supporting runtime #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
Oct 8, 2023
| @@ -13,6 +13,7 @@ pub struct Graph { | |||
| pub entries: Vec<(Option<String>, ModuleId)>, | |||
| pub sorted_modules: Vec<ModuleId>, | |||
| pub symbols: Symbols, | |||
| pub runtime: ModuleId, | |||
There was a problem hiding this comment.
The runtime module put into modules of graph and use runtime to refrence it, but maybe is good to put it to runtime.
|
!bench |
Benchmark Results |
|
ok |
hyf0
changed the title
hyf0
reviewed
Oct 10, 2023
| @@ -50,7 +51,11 @@ impl ModuleTask { | |||
| let mut builder = ModuleBuilder::default(); | |||
| tracing::trace!("process {:?}", self.path); | |||
| // load | |||
| let source = tokio::fs::read_to_string(self.path.as_ref()).await?; | |||
| let source = if RUNTIME_PATH == self.path.as_ref() { | |||
There was a problem hiding this comment.
I'm intending to not include runtime module as the part of making module graph. In this way, we don't need to write such code.
Another way is to have a special ModuleTaskForRuntime to deal with the special logic of runtime module.
I haven't think through which way is better. Let's change it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related #35
Test Plan
no need.