fix: dynamic import chunk is_entry should be false #361
Conversation
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
crates/rolldown/tests/common/case.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn render_stats_to_snapshot(&mut self, assets: Vec<Output>) { |
There was a problem hiding this comment.
Cool. It would be good if you could separate the testing changes in another PR.
I'm not sure if we need this information. I tend to not add this.
There was a problem hiding this comment.
I want to make sure the output stats are tested, Add this to the rust side because it is easy to debugger than js side. Maybe you have another idea for this?
There was a problem hiding this comment.
I'm not sure if we need this information. I tend to not add this.
The information is used at vite, it is also rust exported stats data, it should be tested.
There was a problem hiding this comment.
Any ideas on how rollup or esbuild test this?
There was a problem hiding this comment.
There was a problem hiding this comment.
I removed the test at the pr, it is can merged at now
underfin
force-pushed
the
11-22-fix_dynamic_import_chunk_is_entry_should_be_false
branch
from
f051c35 to
239cf2e
Compare
underfin
force-pushed
the
11-22-fix_dynamic_import_chunk_is_entry_should_be_false
branch
from
239cf2e to
325c04c
Compare
underfin
deleted the
11-22-fix_dynamic_import_chunk_is_entry_should_be_false
branch
Description
Test Plan