-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basic warning mechanism #332
Conversation
1019fc0
to
1b9f941
Compare
What's the reasoning for not using miette's built in diagnostic stuff? |
Let me try to explain. What miette does/The main part it's allow to make diagnostics using dsl/macros. Macros has many limitations. And the expected of In fact we currently have only one error with different error kind, this kind of breaks what miette expected. Other than that, for supporting warnings, we need to display different contents/colors than errors, while miette is designed to work with errors and prefer macros. Maybe we could figure out a way to config it, But than I thought it's probably the same we use |
4ba6c75
to
40d40c1
Compare
1b9f941
to
7cd5f92
Compare
7cd5f92
to
b4ebf32
Compare
Description
Closes #331
How it looks like: https://github.com/rolldown-rs/rolldown/blob/1019fc02a64be334b3b11f9552da96b2ced7d2ba/crates/rolldown/tests/fixtures/warnings/basic/artifacts.snap
Test Plan