feat: print fancy messages for errors #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2023
underfin
reviewed
Nov 19, 2023
| @@ -8,5 +8,12 @@ input_file: crates/rolldown/tests/fixtures/errors/unresolved_entry | |||
| ## UNRESOLVED_ENTRY | |||
|
|
|||
| ```text | |||
| Cannot resolve entry module ./main.js. | |||
| [UNRESOLVED_ENTRY] Error: Unresolved entry module | |||
| ╭─[Output:1:1] | |||
There was a problem hiding this comment.
I think the user maybe will be curious where is Output:1:1
There was a problem hiding this comment.
I feel the same. But I currently don't know how to config ariadne to make it disappear. Probably need to create an issue with a help wanted label :).
hyf0
force-pushed
the
11-19-feat_store_source_in_BuildError_
branch
from
eb63778 to
cf2eb07
Compare
Base automatically changed from
11-19-feat_store_source_in_BuildError_
to
main
November 19, 2023 12:19
hyf0
force-pushed
the
11-19-feat_print_fancy_messages_for_errors
branch
from
fd32dba to
4ba6c75
Compare
hyf0
force-pushed
the
11-19-feat_print_fancy_messages_for_errors
branch
from
4ba6c75 to
40d40c1
Compare
underfin
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just found that we need
ariadnefor better flexbility to control how we display the messages, which is useful when we support warnings.Test Plan