Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce trait BuildErrorLike #327

Merged
merged 1 commit into from
Nov 19, 2023
Merged

feat: introduce trait BuildErrorLike #327

merged 1 commit into from
Nov 19, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 19, 2023

Description

  • Each error should defined as self contained. It includes it's error code and message.
  • I used enum for exposing error kind to rust users of rolldown, and now I think it seems meaningless to care what the errors are.
    • However, I haven't think it through. Let's see when this need is really requires.

Test Plan


@hyf0 hyf0 changed the title feat: introduce \trait BuildErrorLike\ feat: introduce trait BuildErrorLike Nov 19, 2023
@hyf0 hyf0 force-pushed the 11-19-feat_make_BuildError_newtype branch from 675c859 to 6531ad8 Compare November 19, 2023 11:46
@hyf0
Copy link
Member Author

hyf0 commented Nov 19, 2023

Merge activity

  • Nov 19, 7:13 AM: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Nov 19, 7:17 AM: Graphite rebased this pull request as part of a merge.
  • Nov 19, 7:18 AM: @hyf0 merged this pull request with Graphite.

@hyf0 hyf0 force-pushed the 11-19-feat_make_BuildError_newtype branch from 6531ad8 to 26cee3e Compare November 19, 2023 12:15
Base automatically changed from 11-19-feat_make_BuildError_newtype to main November 19, 2023 12:17
@hyf0 hyf0 merged commit 158b11d into main Nov 19, 2023
6 checks passed
@hyf0 hyf0 deleted the 11-19-feat_ branch November 19, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants