-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make BuildError
newtype
#326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2023
This was referenced Nov 19, 2023
hyf0
force-pushed
the
11-19-chore_remove_unused_LinkingInfo_export_from_map_
branch
from
November 19, 2023 11:46
e27194f
to
ed7ff66
Compare
hyf0
force-pushed
the
11-19-feat_make_BuildError_newtype
branch
from
November 19, 2023 11:46
675c859
to
6531ad8
Compare
underfin
approved these changes
Nov 19, 2023
hyf0
force-pushed
the
11-19-chore_remove_unused_LinkingInfo_export_from_map_
branch
from
November 19, 2023 12:14
ed7ff66
to
c582be3
Compare
Base automatically changed from
11-19-chore_remove_unused_LinkingInfo_export_from_map_
to
main
November 19, 2023 12:15
hyf0
force-pushed
the
11-19-feat_make_BuildError_newtype
branch
from
November 19, 2023 12:15
6531ad8
to
26cee3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation for supporting warnings and error tracing. We need add some fields on
BuildError
.Test Plan