Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make BuildError newtype #326

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 19, 2023

Description

This is a preparation for supporting warnings and error tracing. We need add some fields on BuildError.

Test Plan


@hyf0 hyf0 force-pushed the 11-19-chore_remove_unused_LinkingInfo_export_from_map_ branch from e27194f to ed7ff66 Compare November 19, 2023 11:46
@hyf0 hyf0 force-pushed the 11-19-feat_make_BuildError_newtype branch from 675c859 to 6531ad8 Compare November 19, 2023 11:46
@hyf0
Copy link
Member Author

hyf0 commented Nov 19, 2023

Merge activity

  • Nov 19, 7:13 AM: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Nov 19, 7:15 AM: Graphite rebased this pull request as part of a merge.
  • Nov 19, 7:17 AM: @hyf0 merged this pull request with Graphite.

@hyf0 hyf0 force-pushed the 11-19-chore_remove_unused_LinkingInfo_export_from_map_ branch from ed7ff66 to c582be3 Compare November 19, 2023 12:14
Base automatically changed from 11-19-chore_remove_unused_LinkingInfo_export_from_map_ to main November 19, 2023 12:15
@hyf0 hyf0 force-pushed the 11-19-feat_make_BuildError_newtype branch from 6531ad8 to 26cee3e Compare November 19, 2023 12:15
@hyf0 hyf0 merged commit 475907e into main Nov 19, 2023
6 checks passed
@hyf0 hyf0 deleted the 11-19-feat_make_BuildError_newtype branch November 19, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants