Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only import needed runtime symbols #324

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 19, 2023

Description

The fix is done by more delicate analyzing the module type and import kind.

This also fixes #319 (comment).

Test Plan


@hyf0 hyf0 force-pushed the 11-19-fix_only_import_needed_runtime_symbols branch from ff600d2 to b0c104f Compare November 19, 2023 05:44
@hyf0 hyf0 force-pushed the 11-18-fix_ensure_valid_output_for_import_the_same_cjs_twice branch from 3650c1e to 18c85da Compare November 19, 2023 11:45
@hyf0 hyf0 force-pushed the 11-19-fix_only_import_needed_runtime_symbols branch from b0c104f to f5a973d Compare November 19, 2023 11:45
@hyf0
Copy link
Member Author

hyf0 commented Nov 19, 2023

Merge activity

  • Nov 19, 7:13 AM: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Nov 19, 7:13 AM: Graphite rebased this pull request as part of a merge.
  • Nov 19, 7:14 AM: @hyf0 merged this pull request with Graphite.

Base automatically changed from 11-18-fix_ensure_valid_output_for_import_the_same_cjs_twice to main November 19, 2023 12:13
@hyf0 hyf0 force-pushed the 11-19-fix_only_import_needed_runtime_symbols branch from f5a973d to 2a1d4ae Compare November 19, 2023 12:13
@hyf0 hyf0 merged commit 51db31f into main Nov 19, 2023
6 checks passed
@hyf0 hyf0 deleted the 11-19-fix_only_import_needed_runtime_symbols branch November 19, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants