fix: stable generated exports #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
underfin
reviewed
Nov 17, 2023
| @@ -31,7 +31,8 @@ impl Chunk { | |||
| } | |||
| } | |||
|
|
|||
| let export_items = self.get_export_items(graph); | |||
| let mut export_items = self.get_export_items(graph); | |||
| export_items.sort_unstable_by(|a, b| a.0.as_str().cmp(b.0.as_str())); | |||
There was a problem hiding this comment.
The OutputChunk exports is also used it, Could you sort it at get_export_items? Other linking_info .sorted_exports() is also sorted, you only sort the exports_to_other_chunks exports is ok.
hyf0
force-pushed
the
11-17-fix_stable_generated_exports
branch
from
ea53af3 to
d7d3b40
Compare
underfin
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #312.
Test Plan