feat(node): export some types #283
Conversation
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
| export type { RollupOptions, InputOptions, OutputOptions } | ||
|
|
||
| // export types from rollup | ||
| export type { RollupOutput, Plugin } from 'rollup' |
There was a problem hiding this comment.
Cool. It's would be cooler that you could add some contexts here for why we want export rollup types from rolldown.
There was a problem hiding this comment.
It is used because vite using custom plugin type and bundle.write() result type, and also we need to export some compat with rollup types.
There was a problem hiding this comment.
We maybe meet some type not compatible with rollup, also it's difficult to resolve same type at diffre
nt rollup version. So we cant ignore the situation.
There was a problem hiding this comment.
Good. I was planned to remove the `rollup` dependency from the @rolldown/node, it's kind feel strange. Glad to know the contexts. Good job.
underfin
force-pushed
the
11-15-feat_export_some_types
branch
from
4d70a43 to
1a2a15e
Compare
Description
Test Plan