perf: spawn runtime task ASAP #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
milesj
reviewed
Nov 15, 2023
| Arc::clone(&self.resolver), | ||
| ); | ||
|
|
||
| module_loader.try_spawn_runtime_module_task(); |
There was a problem hiding this comment.
being called twice, not sure if intentional
There was a problem hiding this comment.
Yeah. It's designed to be abled called multiple times. The first call is to trigger the task and second is to get the runtime ModuleId.
There was a problem hiding this comment.
But calling twice is not a good sign, I have ideas to solve it, but just too many todos on the schedules.
This was referenced Nov 15, 2023
underfin
approved these changes
Nov 15, 2023
Base automatically changed from
11-15-refactor_RuntimeNormalModuleTask_don_t_rely_on_ModuleTaskCommonData_anymore
to
main
November 15, 2023 06:19
hyf0
force-pushed
the
11-15-perf_spawn_runtime_task_ASAP
branch
from
fdda345 to
1c588b2
Compare
hyf0
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Thank you for contributing! --> ### Description This also reduce the calling times of `try_spawn_runtime_module_task`. #276 (comment) <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> ### Test Plan <!-- e.g. is there anything you'd like reviewers to focus on? --> ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan