Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use @rolldown/core to bench with esbuild #234

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: use @rolldown/core to bench with esbuild #234

merged 1 commit into from
Nov 13, 2023

Conversation

houyunlu
Copy link
Contributor

@houyunlu houyunlu commented Nov 12, 2023 •
edited
Loading

@houyunlu houyunlu changed the title feat: finish bench use @rolldown/core feat: use @rolldown/core to bench with esbuild Nov 12, 2023
underfin
underfin reviewed Nov 13, 2023
View reviewed changes
bench/esbuild.js
await esbuild.build({
entryPoints: entryPoints,
bundle: true,
outfile: 'out.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esbuild here write result to file, but rollldown not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it first, and solve it later.

@hyf0 hyf0 merged commit aa7982b into main Nov 13, 2023
8 checks passed
@hyf0 hyf0 deleted the feat/bench-rolldown-core branch November 13, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

@underfin underfin underfin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark with esbuild using @rolldown/core
3 participants
@houyunlu @underfin @hyf0