Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate module namespace binding on demand #126

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: generate module namespace binding on demand #126

merged 2 commits into from
Oct 30, 2023

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 30, 2023 •
edited
Loading

Description

Test Plan

@hyf0 hyf0 mentioned this pull request Oct 30, 2023
Closed
@hyf0
Copy link
Member Author

hyf0 commented Oct 30, 2023

!bench

@hyf0 hyf0 merged commit e09002f into main Oct 30, 2023
4 checks passed
@hyf0
Copy link
Member Author

hyf0 commented Oct 30, 2023

!bench

@hyf0 hyf0 deleted the hyf_91203908123 branch October 30, 2023 13:03
@github-actions
Copy link

Benchmark Results

group                            baseline                               pr
-----                            --------                               --
rolldown benchmark/threejs       1.04     97.0±5.45ms        ? ?/sec    1.00    93.0±18.40ms        ? ?/sec
rolldown benchmark/threejs10x    1.01   995.8±28.98ms        ? ?/sec    1.00   984.1±55.43ms        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyf0 @underfin