feat: add output chunk isDynamicEntry (#373)

rolldown · Nov 23, 2023 · 7f0e987 · 7f0e987
1 parent 4d44e56
commit 7f0e987
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 9 deletions.
diff --git a/crates/rolldown/src/bundler/bundle/output.rs b/crates/rolldown/src/bundler/bundle/output.rs
@@ -12,6 +12,7 @@ pub struct OutputChunk {
   pub file_name: String,
   pub code: String,
   pub is_entry: bool,
+  pub is_dynamic_entry: bool,
   pub facade_module_id: Option<String>,
   pub modules: FxHashMap<String, RenderedModule>,
   pub exports: Vec<String>,

diff --git a/crates/rolldown/src/bundler/stages/bundle_stage.rs b/crates/rolldown/src/bundler/stages/bundle_stage.rs
@@ -64,6 +64,7 @@ impl<'a> BundleStage<'a> {
           file_name: c.file_name.clone().unwrap(),
           code: content,
           is_entry: matches!(&c.entry_point, Some(e) if e.kind == EntryPointKind::UserSpecified),
+          is_dynamic_entry: matches!(&c.entry_point, Some(e) if e.kind == EntryPointKind::DynamicImport),
           facade_module_id: c.entry_point.as_ref().map(|entry_point| {
             self.link_output.modules[entry_point.module_id].expect_normal().pretty_path.to_string()
           }),

diff --git a/crates/rolldown/tests/common/case.rs b/crates/rolldown/tests/common/case.rs
@@ -93,8 +93,12 @@ impl Case {
       .flat_map(|asset| match asset {
         Output::Chunk(chunk) => {
           vec![Cow::Owned(format!(
-            "- {}, is_entry {}, facade_module_id {:?}, exports {:?}",
-            chunk.file_name, chunk.is_entry, chunk.facade_module_id, chunk.exports
+            "- {}, is_entry {}, is_dynamic_entry {}, facade_module_id {:?}, exports {:?}",
+            chunk.file_name,
+            chunk.is_entry,
+            chunk.is_dynamic_entry,
+            chunk.facade_module_id,
+            chunk.exports
           ))]
         }
         Output::Asset(_) => vec![],

diff --git a/crates/rolldown/tests/fixtures/code_splitting/artifacts.snap b/crates/rolldown/tests/fixtures/code_splitting/artifacts.snap
@@ -32,7 +32,7 @@ import('./dynamic_js.mjs')
 
 ## Output Stats
 
-- 3.mjs, is_entry false, facade_module_id None, exports []
-- dynamic_js.mjs, is_entry false, facade_module_id Some("dynamic.js"), exports []
-- main1.mjs, is_entry true, facade_module_id Some("main1.js"), exports []
-- main2.mjs, is_entry true, facade_module_id Some("main2.js"), exports []
+- 3.mjs, is_entry false, is_dynamic_entry false, facade_module_id None, exports []
+- dynamic_js.mjs, is_entry false, is_dynamic_entry true, facade_module_id Some("dynamic.js"), exports []
+- main1.mjs, is_entry true, is_dynamic_entry false, facade_module_id Some("main1.js"), exports []
+- main2.mjs, is_entry true, is_dynamic_entry false, facade_module_id Some("main2.js"), exports []
diff --git a/crates/rolldown_binding/index.d.ts b/crates/rolldown_binding/index.d.ts
@@ -54,6 +54,7 @@ export interface OutputChunk {
   code: string
   fileName: string
   isEntry: boolean
+  isDynamicEntry: boolean
   facadeModuleId?: string
   modules: Record<string, RenderedModule>
   exports: Array<string>

diff --git a/crates/rolldown_binding/src/output.rs b/crates/rolldown_binding/src/output.rs
@@ -37,6 +37,7 @@ pub struct OutputChunk {
   pub code: String,
   pub file_name: String,
   pub is_entry: bool,
+  pub is_dynamic_entry: bool,
   pub facade_module_id: Option<String>,
   pub modules: HashMap<String, RenderedModule>,
   pub exports: Vec<String>,
@@ -48,6 +49,7 @@ impl From<Box<rolldown::OutputChunk>> for OutputChunk {
       code: chunk.code,
       file_name: chunk.file_name,
       is_entry: chunk.is_entry,
+      is_dynamic_entry: chunk.is_dynamic_entry,
       facade_module_id: chunk.facade_module_id,
       modules: chunk.modules.into_iter().map(|(key, value)| (key, value.into())).collect(),
       exports: chunk.exports,

diff --git a/packages/node/src/utils/transform-to-rollup-output.ts b/packages/node/src/utils/transform-to-rollup-output.ts
@@ -15,6 +15,7 @@ function transformToRollupOutputChunk(chunk: OutputChunk): RollupOutputChunk {
     exports: chunk.exports,
     isEntry: chunk.isEntry,
     facadeModuleId: chunk.facadeModuleId || null,
+    isDynamicEntry: chunk.isDynamicEntry,
     get dynamicImports() {
       return unimplemented()
     },
@@ -33,9 +34,6 @@ function transformToRollupOutputChunk(chunk: OutputChunk): RollupOutputChunk {
     get map() {
       return unimplemented()
     },
-    get isDynamicEntry() {
-      return unimplemented()
-    },
     get isImplicitEntry() {
       return unimplemented()
     },