Use current error_reporting() level to filter errors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -273,6 +274,11 @@ protected function _report_php_error($errno, $errstr, $errfile, $errline) { | |||
| return; | |||
| } | |||
|
|
|||
| if (!(error_reporting() & $errno) && $this->use_error_reporting) { | |||
There was a problem hiding this comment.
I'd switch the order here, so the function call is only made if $this->use_error_reporting is true.
if ($this->use_error_reporting && !(error_reproting() & $errno)) {
|
Thanks for the PR! I think we'll be happy to accept, pending the minor changes above. Adding @sbezboro |
Restored previous behavior for compatibility reasons.
|
Awesome, looks good to me! Merged and released as part of version 0.9.4. Thanks @vilius-g |
|
👍 thanks @vilius-g! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.