Nil Error in Frames Strategy with 1.2.11

[flomotlik]

Error data taken out of Sidekiq Data:

{"filename"=>"/app/vendor/bundle/ruby/2.1.0/gems/rollbar-1.2.11/lib/rollbar/truncation/frames_strategy.rb", "lineno"=>16, "method"=>"call"}], "exception"=>{"class"=>"NoMethodError", "message"=>"undefined method `[]' for nil:NilClass"}}}

It looks to me like the body can't be properly loaded, which might be as we run 1.2.11 and 1.2.10 on different parts of our infrastructure and they might not be compatible.

[flomotlik]

An additional problem then was that the rollbar gem doesn't set the retry limit for the sidekiq worker low or to 0 which when Rollbar itself throws an error means our system gets completely swamped, Redis fills up quickly and everything dies. Sending a PR in a second.

[brianr]

Yikes, thanks @flomotlik. Is this happening for errors that are occurring within your sidekiq workers, or for errors that are happening in your app but are being reported using sidekiq as the async handler?

[flomotlik]

From what I can see is we had an exception in our application, this triggered the sidekiq rollbar worker. The rollbar worker threw an exception and then all hell breaks loose.

[flomotlik]

Some way to limit reporting to exceptions happening outside of the rollbar gem would be nice. Thought about limiting retry, but doesn't actually solve the problem. Currently downgrading to 1.2.10 and hopefully this solves it for now.

[flomotlik]

Downgrade worked fine, everything running smoothly now. Let me know if there is something specific I should look into to help you fix this.

[brianr]

Ok, great. We'll look into this asap.

[jondeandres]

Ok, I think we have the bug detected. When the payload is processed by an async handler the keys are strings instead of symbols, since it's serialized to push it to Redis, and then deserialized.

I'm workig on a fix for this.

[brianr]

Thanks again @flomotlik for reporting this. The fix has been released in 1.2.12 (now up on rubygems).

[beanieboi]

thanks guys, we give it a try!