Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventsbuildingblock dockerfile alpine #513

Merged
merged 31 commits into from
Jul 24, 2020
Merged

Eventsbuildingblock dockerfile alpine #513

merged 31 commits into from
Jul 24, 2020

Conversation

bingzhang
Copy link
Collaborator

No description provided.

bingzhang added 28 commits June 25, 2019 11:02
@bingzhang
remove endDate as required field. add dateCreated and createdBy
9502245
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
1ddc1cb 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
3f12c4b 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
99b02bd 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
f1d19cd 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
90d5734 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
041eae7 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
e0e6154 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
607da0b 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
9c185a3 
…-blocks-api into develop
@bingzhang
Merge tag 'pre-release-1' of https://github.com/rokwire/rokwire-build…
77b86e4 
…ing-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
efe73d1 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
3d1bf88 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
636c126 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
9c6948e 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
444fc4b 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
65ff195 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
ebabac9 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
cb024ac 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
e24ae66 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
c1835bc 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
46b5ef6 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
baafa66 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
42dfc3e 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
47c7fd0 
…-blocks-api into develop
@bingzhang
Merge branch 'develop' of https://github.com/rokwire/rokwire-building…
1a42379 
…-blocks-api into develop
@bingzhang
Merge branch 'eventsbuildingblock_dockerfile_alpine' of https://githu…
6e6b5c5 
…b.com/rokwire/rokwire-building-blocks-api into eventsbuildingblock_dockerfile_alpine
@bingzhang
fix docker vulnerability
ff5bf30
@bingzhang bingzhang added this to the Sprint 23 milestone Jul 22, 2020
@bingzhang bingzhang requested a review from sandeep-ps July 22, 2020 16:08
@sandeep-ps sandeep-ps requested review from ywkim312 and wenjzhu July 22, 2020 16:19
@sandeep-ps sandeep-ps added the open source This issue is to improve something from an open source perspective label Jul 22, 2020
@sandeep-ps
Copy link
Collaborator

@wenjzhu and @ywkim312, with the most recent Alpine version, there is an issue that will break previous docker builds after you pull the latest base image.

You can try this by adding --pull flag in the docker build image command. E.g. docker build --pull -f eventservice/Dockerfile -t rokwire/events-building-block . Please test the fix in this PR and if it works, please apply to the Dockerfiles that you are maintaining. Thanks.

sandeep-ps
sandeep-ps reviewed Jul 22, 2020
View reviewed changes
eventservice/Dockerfile Outdated Show resolved Hide resolved
@bingzhang @sandeep-ps
Update eventservice/Dockerfile
1a49098 
Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
sandeep-ps
sandeep-ps previously approved these changes Jul 24, 2020
View reviewed changes
sandeep-ps
sandeep-ps reviewed Jul 24, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sandeep-ps sandeep-ps merged commit b417112 into develop Jul 24, 2020
@sandeep-ps sandeep-ps deleted the eventsbuildingblock_dockerfile_alpine branch July 24, 2020 17:08
@sandeep-ps sandeep-ps linked an issue Jul 24, 2020 that may be closed by this pull request
[TASK] Fix Docker image vulnerability in Events BB #484
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeep-ps sandeep-ps sandeep-ps approved these changes

@ywkim312 ywkim312 Awaiting requested review from ywkim312

@wenjzhu wenjzhu Awaiting requested review from wenjzhu

Assignees

@bingzhang bingzhang

Labels
open source This issue is to improve something from an open source perspective
Projects
None yet
Milestone
Sprint 23
Development

Successfully merging this pull request may close these issues.

[TASK] Fix Docker image vulnerability in Events BB
2 participants
@bingzhang @sandeep-ps