Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/486 update api doc docker file to use multiple open api specifications #503

Merged
merged 14 commits into from
Jul 17, 2020
Merged

Task/486 update api doc docker file to use multiple open api specifications #503

merged 14 commits into from
Jul 17, 2020

Conversation

sandeep-ps
Copy link
Collaborator

Closes #486

sandeep-ps added 13 commits July 10, 2020 13:50
@sandeep-ps
Use separate OpenAPI specification file for Profile Building Block.
e5f53ef
@sandeep-ps
Use separate OpenAPI specification file for Logging Building Block.
956809b
@sandeep-ps
Use separate OpenAPI specification file for Events Building Block.
3cfedc9
@sandeep-ps
Use separate OpenAPI specification file for Auth Building Block. Othe…
a489f64 
…r minor updates.
@sandeep-ps
Use separate OpenAPI specification file for App Config Building Block.
077d30a
@sandeep-ps
Update CHANGELOG.
3f6e5ae
@sandeep-ps
Merge branch 'develop' into task/485-split-rokwire-yaml-across-differ…
cabd16e 
…ent-building-blocks
@sandeep-ps
Merge branch 'develop' into task/485-split-rokwire-yaml-across-differ…
2790fa8 
…ent-building-blocks
@sandeep-ps
Update Docker file.
5e10b49
@sandeep-ps
Update README.
d2ac8f6
@sandeep-ps
Remove rokwire.yaml.
2a4e2af
@sandeep-ps
Remove scripts in the deployement folder as it's not being used at th…
e1f9678 
…is time.
@sandeep-ps
Update CHANGELOG.
ea37a21
@sandeep-ps sandeep-ps added the open source This issue is to improve something from an open source perspective label Jul 16, 2020
@sandeep-ps sandeep-ps added this to the Sprint 23 milestone Jul 16, 2020
@sandeep-ps sandeep-ps self-assigned this Jul 16, 2020
ywkim312
ywkim312 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both logging and profiles. Codes look okay and testing on both local and docker worked okay.

@wenjzhu
Copy link
Contributor

wenjzhu commented Jul 16, 2020

Tested both appconfig and auth and they worked ok.

@sandeep-ps sandeep-ps merged commit 9416bea into develop Jul 17, 2020
@sandeep-ps sandeep-ps deleted the task/486-update-API-Doc-Docker-file-to-use-multiple-OpenAPI-specifications branch July 17, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenjzhu wenjzhu wenjzhu approved these changes

@ywkim312 ywkim312 ywkim312 approved these changes

@bingzhang bingzhang bingzhang approved these changes

Assignees

@sandeep-ps sandeep-ps

Labels
open source This issue is to improve something from an open source perspective
Projects
None yet
Milestone
Sprint 23
Development

Successfully merging this pull request may close these issues.

[TASK] Update API Doc Docker file to use multiple OpenAPI specifications
4 participants
@sandeep-ps @wenjzhu @bingzhang @ywkim312