Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change category names #1180

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

bingzhang
Copy link
Collaborator

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@bingzhang bingzhang self-assigned this Sep 7, 2023
@bingzhang bingzhang requested a review from minump as a code owner September 7, 2023 16:30
@bingzhang bingzhang linked an issue Sep 7, 2023 that may be closed by this pull request
@sandeep-ps
Copy link
Collaborator

Please make the above changes. The rest looks good to me. Thanks.

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@bingzhang
Copy link
Collaborator Author

Please make the above changes. The rest looks good to me. Thanks.

update category names.

Copy link
Collaborator

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this PR. Thanks.

Copy link
Collaborator

@minump minump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Approved

@bingzhang bingzhang merged commit 970cfa6 into develop Sep 7, 2023
2 checks passed
@bingzhang bingzhang deleted the 1179-feature-change-category-names branch September 7, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Change category names
3 participants