Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make rokwire api doc not going to 8080 #97

Closed
xialiao opened this issue Jun 18, 2019 · 9 comments
Closed

[BUG] Make rokwire api doc not going to 8080 #97

xialiao opened this issue Jun 18, 2019 · 9 comments

Comments

@xialiao
Copy link
Contributor

xialiao commented Jun 18, 2019

Description

Currently if clicking on https://api.rokwire.illinois.edu/api/docs, my browser (Chrome) would redirect to http://...:8080/api/docs which is undesirable.

It seems there is some configuration in swagger docker that needs to be addressed.

Workaround

Use https://api.rokwire.illinois.edu/api/docs/ with / at the end.

Acceptance Criteria

not redirect to 8080

@xialiao xialiao self-assigned this Jun 18, 2019
@mtorrison mtorrison added this to the Sprint 9 milestone Jun 24, 2019
@mtorrison
Copy link

@sandeep-ps will review milestone assignment

@mtorrison
Copy link

Our MVP commitment was to have App Config complete by EO July. Pulling this task back in Sprint 10

@sandeep-ps
Copy link
Collaborator

Based on our discussion, moving this task to sprint 11 as it is not related to App Config.

@sandeep-ps
Copy link
Collaborator

This looks like a known bug in Swagger.
swagger-api/swagger-ui#5409

@xialiao
Copy link
Contributor Author

xialiao commented Jul 23, 2019

Yes, I am aware of those two,

swagger-api/swagger-ui#5409

swagger-api/swagger-ui#4385

Does Brown Dog use Swagger UI docker image?

@sandeep-ps
Copy link
Collaborator

sandeep-ps commented Jul 23, 2019

Does Brown Dog use Swagger UI docker image?

No, I just confirmed. We are running Swagger UI as static web app and giving the JSON file to render.

For Sprint 11 (2nd Group), one temporary solution could be to run rokwire.yaml using Docker without BASE_URL and do the redirection in AWS. As this is a bug in Swagger with an open pull request (swagger-api/swagger-ui#5409), unless they merge that pull request we cannot probably use BASE_URL without running into this issue.

@xialiao
Copy link
Contributor Author

xialiao commented Aug 8, 2019

Using just mapping does not work. Have to wait until the Swagger container to make the fix.

@mtorrison
Copy link

Not yet finished; @sandeep-ps will complete or assign another dev (XX OOO next 2 weeks)

@sandeep-ps
Copy link
Collaborator

This is happening evening with Swagger container #188. I don't think it's important to look into this at this time. Things are work fine with trailing slash in the URL. Closing this now. Will reopen if we find a solution in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants