Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file icon for .brs files #32

Closed
TwitchBronBron opened this issue Nov 20, 2018 · 4 comments
Closed

Add file icon for .brs files #32

TwitchBronBron opened this issue Nov 20, 2018 · 4 comments
Labels
enhancement

Comments

@TwitchBronBron
Copy link
Member

VSCode shows images next to the file for known file types, like this:
image

We should create an icon for the brightscript .brs extension.
@TwitchBronBron
Copy link
Member Author

I did some research and couldn't find a way to do this without creating a whole icon theme. I asked this question on stackoverflow. Hopefully someone will know the answer!

@TwitchBronBron
Copy link
Member Author

There is an open feature request at the vscode githut project here.

@TwitchBronBron
Copy link
Member Author

Looks like that feature has landed. Here's how we would contribute the icon:
microsoft/vscode#140047 (comment)

@TwitchBronBron
Copy link
Member Author

This was implemented in #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TwitchBronBron