Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking for test naming collisions needs improvements with Params tests - can lead to vague error messages for params #5

Closed
georgejecook opened this issue Sep 20, 2018 · 0 comments

Comments

@georgejecook
Copy link
Collaborator

Naming collisions for tests need better handling. If a naming collision occurs for a test with params, and there is a mismatch in param types, then it can lead to unclear crash scenarios because the params test is still added, so it is applied to the original (collided) test case.

Need to take care to ensure that any params test case, which is part of a name-collided test does not get added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant