Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use micromatch instead of picomatch #109

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Use micromatch instead of picomatch #109

merged 3 commits into from
Mar 14, 2023

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Mar 14, 2023

We use fast-glob for file discovery (which uses micromatch for glob logic), but for some reason were using picomatch for our path filtering logic.

This PR aligns on micromatch for path filtering logic, meaning that now all glob logic within roku-deploy is handled using the same library.

@philippe-wm
Copy link

But is that the same version as fast-glob is using otherwise that would be duplicated anyway?

Align micromatch version with one from fast-glob
@TwitchBronBron
Copy link
Member Author

But is that the same version as fast-glob is using otherwise that would be duplicated anyway?

Good call! There was a patch release of fast-glob (3.2.11 -> 3.2.12), so I upgraded that, and then aligned our version of micromatch with the one from fast-glob (4.0.4)

@TwitchBronBron TwitchBronBron merged commit 7cc9063 into master Mar 14, 2023
@TwitchBronBron TwitchBronBron deleted the micromatch branch March 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants