Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much better responses from the various functions #122

Open
TwitchBronBron opened this issue Nov 3, 2023 · 0 comments
Open

Much better responses from the various functions #122

TwitchBronBron opened this issue Nov 3, 2023 · 0 comments
Milestone

Comments

@TwitchBronBron
Copy link
Member

TwitchBronBron commented Nov 3, 2023

Sometimes roku-deploy just returns a string as the response from doing something. That's not overly helpful .We should do a much better job return a structured response/status object so the callers can make more informed decisions about this stuff.

Problems to solve:

  • roku has info, warn, error stuff. we're not logging those. we should. So if we're gonna throw, we should log better reasons why.
  • our tools like vscode are likely not taking advantage of this when it could. we're just looking at "it threw" and logging it. We should try passing along info, warn, error stuff to the console.

We might need to append rokuMessages to every error.

interface RokuDeployError {
    message: string;
    stack: any;
    rokuMessages: RokuMessages;
}
@TwitchBronBron TwitchBronBron removed the v4 label Feb 1, 2024
@TwitchBronBron TwitchBronBron added this to the v4.0.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant