Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roku-deploy does not respect bsconfig.json #103

Open
iBicha opened this issue Nov 25, 2022 · 3 comments
Open

roku-deploy does not respect bsconfig.json #103

iBicha opened this issue Nov 25, 2022 · 3 comments

Comments

@iBicha
Copy link

iBicha commented Nov 25, 2022

My bsconfig.json looks like this

{
    "extends": "config/bsconfig.base.json",
   ...
}

But roku deploy does not seem to read from config/bsconfig.base.json

Making this fails (because it's looking in the wrong staging folder)

rokuDeploy.zipPackage({
    outDir: '.',
    outFile: zip_name
}).then(function(){
    console.log(`${zip_name} created`)
}, function(error) {
    console.error(error);
});
@TwitchBronBron
Copy link
Member

Currently roku-deploy doesn't support the extends field in bsconfig.json.

public getOptions(options: RokuDeployOptions = {}) {

The best way to fix this would be to centralize the bsconfig.json loading logic so we can share it between roku-deploy and brighterscript, but another quicker option would be to just copy the bsconfig.json loading logic from brighterscript into roku-deploy.

@iBicha
Copy link
Author

iBicha commented Dec 7, 2022

@TwitchBronBron
Copy link
Member

That would end up with a weird circular dependency, because brighterscript depends on roku-deploy, and roku-deploy would then depend on brighterscript. npm might resolve them fine, but I think it would be better to keep the dependency one-way (brighterscript->roku-deploy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants