Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link children to their parents in AST #650

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Jul 22, 2022

Several fixes:

  • link every child expression/statement to its parent at the beginning of the onFileValidate event. This highly simplifies language service based queries that need to walk up the expression chain to find parent expressions or statements
  • use AST walk for BrsFile validation instead of references
  • add getSymbolTable() to every AST node to simplify finding the correct symbols.

@TwitchBronBron TwitchBronBron changed the title Perf improvements Link children to their parents in AST Aug 2, 2022
@TwitchBronBron TwitchBronBron marked this pull request as ready for review August 2, 2022 14:55
@TwitchBronBron TwitchBronBron merged commit 2695401 into master Aug 2, 2022
@TwitchBronBron TwitchBronBron deleted the parent-linking branch August 2, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant