Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ClassFieldStatement and ClassMethodStatement #582

Merged
merged 2 commits into from
May 6, 2022

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented May 6, 2022

#575 will need to reuse the ClassFieldStatement and ClassMethodStatement. This PR renames those to FieldStatement and MethodStatement respectively so they apply more generically across the project.

Backwards compatibility is retained by some javascript trickery, but these items will be removed in v1.

@markwpearce markwpearce self-requested a review May 6, 2022 19:34
Copy link
Collaborator

@markwpearce markwpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@TwitchBronBron TwitchBronBron merged commit d598550 into master May 6, 2022
@TwitchBronBron TwitchBronBron deleted the class-member-refactor branch May 6, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants