Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src path in v0 #581

Merged
merged 4 commits into from
May 6, 2022
Merged

Src path in v0 #581

merged 4 commits into from
May 6, 2022

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented May 3, 2022

  • Renames pathAbsolute to srcPath to align with the naming change in v1.
  • changes all internal calls to getFileByPathAbsolute to getFile
  • adds pathAbsolute getter and setter to provide backwards compatibility support.

There's a small chance that this is a breaking change to plugins, but since we have the ability to lock bsc versions in vscode, I consider these acceptable risks.

  • if a plugin locks to an exact version of bsc, and vscode updates to a new version of bsc, the diagnostics produced by the latest bsc might cause the plugin to crash when looking for pathAbsolute.

NOTE: I tested this change while using bslint against the fubo codebase, and it still works, so I'm pretty comfortable with this change not breaking back-compat for most projects.

@TwitchBronBron TwitchBronBron merged commit 292de71 into master May 6, 2022
@TwitchBronBron TwitchBronBron deleted the srcPath-in-v0 branch May 6, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant