Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds language support for Interface statements #426

Merged
merged 9 commits into from
Jun 29, 2021
Merged

Conversation

TwitchBronBron
Copy link
Member

Adds interface statements to the language. This PR doesn't do much with them other than allow them to be parsed and included in the AST. Future PRs will probably do more with then.

Is there anything else we need to address in this initial PR?

@elsassph
Copy link
Contributor

elsassph commented Jun 2, 2021

Are interface functions appearing in the AST as empty functions?

@TwitchBronBron
Copy link
Member Author

Are interface functions appearing in the AST as empty functions?

Yes? Here's the logic in the parser that creates the new InterfaceMethodStatement.

https://github.com/rokucommunity/brighterscript/pull/426/files#diff-0d27a1b5098cc3c9f464ebe55376e540e5ffd0779dd682227eb284abf03e6478R384

@markwpearce
Copy link
Collaborator

In my “class symbol tables” PR, I added a symbol table to all BscTypes, which is very similar to this idea! 👍
We just need to refactor this PR to match.

@TwitchBronBron TwitchBronBron merged commit 49cbccd into master Jun 29, 2021
@TwitchBronBron TwitchBronBron deleted the feat/interface branch June 29, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants