Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chokidar to support M1 macs #386

Merged
merged 3 commits into from
May 6, 2021
Merged

Upgrade chokidar to support M1 macs #386

merged 3 commits into from
May 6, 2021

Conversation

TwitchBronBron
Copy link
Member

I heard that the bsc watch mode doesn't work with M1 macs. I don't have a mac, but I did find this GitHub issue stating that a recent chokidar release supports mac M1, so i'm upgrading BSc to use that version. It shouldn't cause any issues? I'll need someone with an M1 mac to test this build out.

Copy link
Contributor

@chrisdp chrisdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my M1 MacBook Pro with both watchers and without and looks good. No issues found.

@chrisdp chrisdp merged commit c7f86cc into master May 6, 2021
@chrisdp chrisdp deleted the upgrade-chokidar branch May 6, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants