Iife parse #343
Merged
Iife parse #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Feb 27, 2021
| (expression.callee as any).callee | ||
| (expression.callee as any).callee || | ||
| //filter out callees without a name (immediately-invoked function expressions) | ||
| !(expression.callee as any).name |
There was a problem hiding this comment.
This was the fix for the crash. IIFEs don't have a name, but further down in this function we expected the expression.callee to have a name token. So now we guard against any callee without a name.
TwitchBronBron
commented
Feb 27, 2021
| const func = this.functionDeclaration(true); | ||
| //if there's an open paren after this, this is an IIFE | ||
| if (this.check(TokenKind.LeftParen)) { | ||
| return this.finishCall(this.advance(), func); |
There was a problem hiding this comment.
Roku supports non-grouped IIFE. example:
print function()
return true
end function()
This adds parser support for that pattern.
elsassph
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug in BrsFile that would crash entire file parsing if the file contained an immediately-invoked-function-expression.
Also supports non-grouped IIFEs (gross, but technically valid syntax...so we should support it).