Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins as factory #272

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Plugins as factory #272

merged 5 commits into from
Jan 15, 2021

Conversation

TwitchBronBron
Copy link
Member

There is a flaw in the plugins system right now that always creates a singleton. which pushes the oweness of multi-projects on to each plugin. to combat this, the plugin system has been refactored to require plugins to register a singleton FACTORY, which returns a new plugin instance every time it's called.

@TwitchBronBron TwitchBronBron merged commit ac5203d into master Jan 15, 2021
@TwitchBronBron TwitchBronBron deleted the plugins-as-factory branch January 15, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant