Class name collision #246
Merged
Class name collision #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor class lookup to be a map.
TwitchBronBron
commented
Nov 19, 2020
elsassph
reviewed
Nov 19, 2020
src/DiagnosticMessages.ts
Outdated
| @@ -590,6 +590,11 @@ export let DiagnosticMessages = { | |||
| message: `There are multiple components with the name '${componentName}'`, | |||
| code: 1115, | |||
| severity: DiagnosticSeverity.Error | |||
| }), | |||
| functionCannotHaveSameNameAsClass: (className: string) => ({ | |||
| message: `Function cannot have the same name as class '${className}'`, | |||
There was a problem hiding this comment.
Maybe more consistent with LocalVar message?
There was a problem hiding this comment.
@elsassph which LocalVar message are you referring to?
There was a problem hiding this comment.
Oh, this one: localVarSameNameAsClass. Yeah, good call. It's subtle, but they should be consistent.
src/Scope.ts
Outdated
| if (lowerFuncName) { | ||
|
|
||
| //find function declarations with the same name as a stdlib function | ||
| if (globalCallableMap.has(func.getName(ParseMode.BrighterScript))) { |
There was a problem hiding this comment.
oh yeah, good catch! I fixed it and added this unit test to ensure it doesn't regress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch when local variables and scope functions have the same name as a class.
Fixes #245