Use in-memory source code for diagnostic printing #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntents, and allowing in-memory files to be used, not failing when there is no content, and improving efficiency
TwitchBronBron
changed the title
src/ProgramBuilder.ts
Outdated
| let severity = typeof diagnostic.severity === 'number' ? diagnostic.severity : DiagnosticSeverity.Error; | ||
| //format output | ||
| printDiagnostic(options, severity, filePath, lines, diagnostic); | ||
| try { |
There was a problem hiding this comment.
We should not be wrapping and then throwing away any runtime exceptions that happen here...that would cause even more confusion for plugin authors and developers because there wouldn't even be runtime error messages or stack traces if something went wrong.
| //load the file text | ||
| let fileText = await util.getFileContents(pathAbsolute); | ||
| let lines = util.getLines(fileText); | ||
| const file = this.program.getFileByPathAbsolute(pathAbsolute); |
There was a problem hiding this comment.
This loads the file contents from the in-memory BrsFile/XmlFile. Previously the contents were being loaded from disk, which does not work for in-memory-only files injected by plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves diagnostic printing, by going to program to retrieve file contents, and allowing in-memory files to be used, not failing when there is no content, and improving efficiency