Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all the BrsFile fields need to be filled at parse time #210

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

elsassph
Copy link
Contributor

Some fields are really needed only when we actively use code completion on one file so it should be computed on demand.
This cuts up to 30% parsing time.

@TwitchBronBron
Copy link
Member

Great catch!

@TwitchBronBron TwitchBronBron merged commit dd84831 into rokucommunity:master Oct 12, 2020
@elsassph elsassph deleted the fix/defer-some-work branch February 3, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants