Allow negative patterns in diagnostic filters #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature lets users prefix a glob with
!to make it a negative pattern which un-ignores certain errors. My use case for this is one which I've added to the documentation; I want to ignore errors from all dependencies in a project except for one specific dependency, and I don't want to have to maintain a list of all other dependencies any time one is added or moved.Using file paths to indicate un-ignores means that it's not possible to un-ignore a code without specifying a file path. A workaround for this is to use the glob
!*/**/*, matching everything in the rootDir. I've added this to the documentation and the tests.The implementation is such that it's possible to un-un-un-un-ignore patterns to any depth. This is likely overkill and would be inadvisable to do in practice, but I think the semantics of this are actually simpler and more familiar than it would be to have things bottom out at a specific level.