Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please keep parameter types and return value in definitions when they are interfaces or enums #756

Closed
ZeeD opened this issue Dec 6, 2022 · 2 comments · Fixed by #757
Closed

Comments

@ZeeD
Copy link
Contributor

ZeeD commented Dec 6, 2022

When bsc emit the definitions it seems that both enums and interfaces are missing.

starting from this example.bs

interface Foo
    field as string
end interface

enum Bar
    value
end enum

function baz(parameter as Foo) as Bar
    return Bar.value
end function

the example.d.bs file generated is

interface Foo
    field as string
end interface

enum Bar
    value
end enum
function baz(parameter as object) as object
end function

now baz has lost the type definition and return value information.

I'm using

$ npx bsc --version
0.60.6
@TwitchBronBron
Copy link
Member

TwitchBronBron commented Dec 6, 2022

Nice catch! I just put up PR #757 to address this.

@TwitchBronBron
Copy link
Member

This has been fixed in v0.61.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants