False negatives for BS1011 (same name as global function)

[TwitchBronBron]

This is false.

src/components/RALETRackerTask.brs:417:5 - undefined BS1011: Local var 'str' has same name as global function in 'platform' and will never be called.
417 str = number.toStr()
417 ~~~

[TwitchBronBron]

There was definitely a reason I created this rule, so I'm thinking it's just overreaching and applying to situations it was not intended. I need to create an exhaustive list of possible ways to override parent scope methods and narrow this checking to only the situations that apply.

[TwitchBronBron]

@georgejecook I ran a few tests, and here are the results:

1. Source Scope : override built-in function with own function

sub main()
    str = function(p)
        return "override"
    end function
    print str(12345) 'prints "12345" (i.e. our local function is never used)
end sub

2. Source scope: override built-in function with own variable

sub main()
    str = 12345
    print str ' prints "12345" (i.e. our local variable overrode the name)
end sub

3. Source scope: override built-in function with own variable and call it

sub main()
    str = 6789
    print str(12345) ' prints "12345" (i.e. our local variable did not override the callable global function)
end sub

4. source scope: override same-scope function with own function

sub main()
    getHello = function()
        return "override"
    end function
    print getHello() 'prints "hello" (i.e. our local variable is never used)
end sub

function getHello()
    return "hello"
end function

5. source scope: override same-scope function with own variable

sub main()
    getHello = "override"
    print getHello ' prints <Function: gethello> (i.e. local variable override does NOT work for same-scope-defined methods)
end sub
function getHello()
    return "hello"
end function

6. Scope function with same name as built-in-function

sub main()
    print str(12345) ' prints 12345 (i.e. our str() function below is ignored)
end sub
function str(num)
    return "override"
end function

Conclusion

• BS1011 should be shown for 1 and 4.
• 2 and 3 should not have any error.
• 5 should get its own error message
• 6 should get its own error message.