Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex literal syntax bug #455

Closed
TwitchBronBron opened this issue Oct 1, 2021 · 0 comments · Fixed by #458
Closed

Regex literal syntax bug #455

TwitchBronBron opened this issue Oct 1, 2021 · 0 comments · Fixed by #458
Assignees
@TwitchBronBron
Labels
bug Something isn't working

Comments

@TwitchBronBron
Copy link
Member

There's a critical bug in the regular expression literal feature introduced by #94. The lexer parses all text starting with slash and ending with slash (and optionally including the flags). This will fail for the following code:

marginLeft = m.top.width/2 - m.top.loadingLabel.boundingRect().width/2
@TwitchBronBron TwitchBronBron added the bug Something isn't working label Oct 1, 2021
@TwitchBronBron TwitchBronBron self-assigned this Oct 4, 2021
@TwitchBronBron TwitchBronBron mentioned this issue Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TwitchBronBron TwitchBronBron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs when parsing regex rokucommunity/brighterscript
1 participant
@TwitchBronBron