Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes that fail to apply should be indicated in the patch visualizer somehow #712

Closed
Dekkonot opened this issue Jul 5, 2023 · 1 comment · Fixed by #717
Closed

Changes that fail to apply should be indicated in the patch visualizer somehow #712

Dekkonot opened this issue Jul 5, 2023 · 1 comment · Fixed by #717
Assignees
@boatbomber
Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@Dekkonot
Copy link
Member

Dekkonot commented Jul 5, 2023

Right now, patches can fail to apply fully. This happens e.g. when trying to sync Lighting.Technology.

PR #692 adds an indicator that the sync info label can be clicked to view a patch and also indicate when a change failed to apply. The patch visualization however has no indication of what change failed. I think it'd be helpful to have it be indicated somehow.

Right now, we emit a warning in the plugin when a change couldn't be made. It would be great to have a GUI visualization as well.
@Dekkonot Dekkonot added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin labels Jul 5, 2023
@boatbomber
Copy link
Member

Work is underway!
image

@boatbomber boatbomber self-assigned this Jul 8, 2023
@boatbomber boatbomber added the status: in-progress Someone is working on this last time we checked. label Jul 8, 2023
@boatbomber boatbomber mentioned this issue Jul 8, 2023
Merged
@kennethloeffler kennethloeffler removed the status: in-progress Someone is working on this last time we checked. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boatbomber boatbomber

Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show failed to apply in visualizer boatbomber/rojo
3 participants
@Dekkonot @kennethloeffler @boatbomber