Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trait for mmap-able? #51

Closed
oxinabox opened this issue Oct 8, 2019 · 2 comments
Closed

Add trait for mmap-able? #51

oxinabox opened this issue Oct 8, 2019 · 2 comments
Labels
enhancement New feature or request RFC
Milestone

Comments

@oxinabox
Copy link
Contributor

oxinabox commented Oct 8, 2019

c.f. https://github.com/JuliaData/CSV.jl/pull/511/files#r332346349

Note that some FilePaths can be mmaps directly, in particular SystemPaths
other cannot, like AWS3.S3Paths
But I guess that can be fairly easily handled by treating SystemPaths like strings,
and all other AbstractPaths like Cmds etc.

This would be a nice usecase for JuliaLang/julia#32732
when I eventually make that work,
since then can just compile-time know if something overload's hasmethod(MMap.mmap, ...)

OTOH, I suspect that only SystemPath's are ever going to be mmap-able.
So maybe htis don't need to be extensable,
and existing differentiation between SystemPaths and all other paths is enough.
If so, we can close this

@rofinn rofinn added RFC enhancement New feature or request labels Apr 9, 2020
@rofinn rofinn added this to the 2.0 milestone Apr 15, 2020
@rofinn
Copy link
Owner

rofinn commented May 4, 2020

Hmmm, looks like this may be a requirement to have filepaths work with JLD2.jl? I think it might make sense to have a fallback for non-system paths where we download non-system paths locally and then call MMap.map?

@rofinn
Copy link
Owner

rofinn commented Jun 30, 2020

For now I think we’re just going to support mmap for SystemPaths. If folks want to consistently mmap files then they can cp the file to a temp directory and mmap that.

@rofinn rofinn closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFC
Projects
None yet
Development

No branches or pull requests

2 participants