Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining arrow syntax fix introduces trailing whitespaces #695

Closed
jairojunior opened this issue Apr 5, 2017 · 1 comment
Closed

Chaining arrow syntax fix introduces trailing whitespaces #695

jairojunior opened this issue Apr 5, 2017 · 1 comment

Comments

@jairojunior
Copy link

Steps to reproduce:

git clone https://github.com/biemond/biemond-wildfly.git
git checkout 'v1.2.7'

rake lint
manifests/datasources/datasource.pp - WARNING: arrow should be on the right operand's line on line 14
manifests/datasources/xa_datasource.pp - WARNING: arrow should be on the right operand's line on line 15
manifests/deployment.pp - WARNING: arrow should be on the right operand's line on line 29
manifests/init.pp - WARNING: arrow should be on the right operand's line on line 55
manifests/init.pp - WARNING: arrow should be on the right operand's line on line 56
manifests/init.pp - WARNING: arrow should be on the right operand's line on line 57
manifests/install.pp - WARNING: arrow should be on the right operand's line on line 24
manifests/modcluster/config.pp - WARNING: arrow should be on the right operand's line on line 33
manifests/modcluster/config.pp - WARNING: arrow should be on the right operand's line on line 38
manifests/patch/online.pp - WARNING: arrow should be on the right operand's line on line 15
manifests/security/domain.pp - WARNING: arrow should be on the right operand's line on line 31
manifests/security/domain.pp - WARNING: arrow should be on the right operand's line on line 39
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 167
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 172
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 179
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 187
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 200
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 239
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 254
manifests/security/ldap_realm.pp - WARNING: arrow should be on the right operand's line on line 273
manifests/service.pp - WARNING: arrow should be on the right operand's line on line 37
manifests/undertow/https.pp - WARNING: arrow should be on the right operand's line on line 36
manifests/undertow/https.pp - WARNING: arrow should be on the right operand's line on line 46

And after puppet-lint --fix manifests I got

manifests/datasources/datasource.pp - ERROR: trailing whitespace found on line 14
manifests/datasources/xa_datasource.pp - ERROR: trailing whitespace found on line 15
manifests/deployment.pp - ERROR: trailing whitespace found on line 29
manifests/install.pp - ERROR: trailing whitespace found on line 24
manifests/modcluster/config.pp - ERROR: trailing whitespace found on line 33
manifests/modcluster/config.pp - ERROR: trailing whitespace found on line 38
manifests/patch/online.pp - ERROR: trailing whitespace found on line 15
manifests/service.pp - ERROR: trailing whitespace found on line 37
manifests/undertow/https.pp - ERROR: trailing whitespace found on line 36
manifests/undertow/https.pp - ERROR: trailing whitespace found on line 46
@jairojunior
Copy link
Author

jairojunior commented Apr 5, 2017

Looks like puppet-lint isn't ready to fix this case:

resource_a {}
->
resource_b {}

If the arrow is in a new line, puppet-lint does not remove the line the arrow was at introducing a new issue. (Trailing whitespace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant