Excessive number of warnings from code_on_top_scope

[paran1]

code_on_top_scope.pp:
$foo = 'bar'

Expected number of warnings: 1
Actual number of warnings: 3

$ puppet-lint --with-context code_on_top_scope.pp 
WARNING: code outside of class or define block - foo on line 1

  $foo = 'bar'
  ^

WARNING: code outside of class or define block - = on line 1

  $foo = 'bar'
       ^

WARNING: code outside of class or define block - bar on line 1

  $foo = 'bar'
         ^

$ 

Of course the amount of warnings explode further for example if you assign a global variable using a selector.

[rnelson0]

@paran1 Nice! Can you confirm what version you are on, and if you are pulling from rubygems or a git reference/HEAD?

[paran1]

Oh, sorry! I am at current master (041b430), but the behaviour is the same on 3.0.0. Previous versions didn't include this check.

[paran1]

I just realized that 3.0.0 is a branch rather than a tagged version, so please ignore that. This check is not in any released version.

[rnelson0]

This does seem excessive. I opened #590 to disable this by default 1) because it's a change to the default plugins that does not match a style guide reference and 2) it probably needs updated to generate one warning per line, not token.

[rnelson0]

Closed via #590