Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines with trailing whitespace triggers redundant soft tabs error. #478

Closed
james-powis opened this issue Jun 22, 2016 · 3 comments
Closed

Comments

@james-powis
Copy link

Using version 2.0.0 of the gem the manifest on an empty line without spacing equiling the two-space soft tab we get this following:
manifests/jenkins.pp - ERROR: trailing whitespace found on line 34
manifests/jenkins.pp - ERROR: two-space soft tabs not used on line 34

Where as with the two-space soft tab we get:
manifests/jenkins.pp - ERROR: trailing whitespace found on line 34

Where as on version 1.1.0 with 2 space soft-tabs on an empty line produces no errors.

@dioni21
Copy link
Contributor

dioni21 commented Jun 22, 2016

@james-powis you mean a line with only two spaces in it? IMHO, puppet-lint is now correct, and was wrong before.

Probably your editor is leaving these spaces, but it can surely be configured not to.

@rnelson0
Copy link
Collaborator

The trailing whitespace error is correct, that should not be there.

However, the soft tabs error, while technically correct, is nonsensical, since it's in trailing whitespace. Fixing that remedies the other error, so in this case soft tabs should be suppressed.

@rnelson0 rnelson0 changed the title empty lines with and without indent cause lint errors Empty lines with trailing whitespace triggers redundant soft tabs error. Jun 22, 2016
@james-powis
Copy link
Author

you are absolutely correct... VIM was failing to remove the whitespace... hitting x did the trick... closing as my stupidity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants