-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to disable some fix ? #383
Comments
The point of that check is that if you only describe the mode with three digits, you are not fully describing a file, which has four digits. Puppet will only manage those three digits and not the forth which leads to configuration drift and likely security issues. Since we are defining state, we want to define the entire state of a given mode, not just the part that you might be familiar with. |
My understanding was that puppet will add the extra
@ghoneycutt Can you confirm that my assumption is wrong. My ruby is rusty and I cannot really figure it out looking at the source: |
@PierreR while I agree with @ghoneycutt here that you should put the leading 0 in your file modes rather than relying on the internal behaviour of Puppet (because being explicit leads to less suprises), you can just disable that check if you don't want to puppet-lint to warn on it (which will also skip automatically fixing it when run with |
@rodjek Thanks for mentioning that disabling a check will also skip fixing. I guess I have missed this from the README. Also I would have appreciated a more explicit answer. Is the |
Is there a way to disable some fix (the same way we disable check) ?
For instance I don't really see the point of this fix:
Does
puppet-lint --fix
take into account the--no-file_mode-check
?As a final note, ideally I would like to keep the
file_mode
check but only disable themode should be represented as a 4 digit octal value or symbolic mod
check because I don't see the point of it right now. It looks like the puppetlabs code examples generally don't touch the suid bit.The text was updated successfully, but these errors were encountered: